Fix STOPF timeout not working in I2C_IsErrorOccurred

STMicroelectronics / STM32CubeWB

Full Firmware Package for the STM32WB series: HAL+LL drivers, CMSIS, BSP, MW, plus a set of Projects (examples and demos) running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits).

https://www.st.com/en/embedded-software/stm32cubewb.html

Other

227 stars 138 forks source link

Fix STOPF timeout not working in I2C_IsErrorOccurred #66

Closed paussems closed 1 year ago

paussems commented 2 years ago

When STOPF is never set, the I2C_IsErrorOccurred function looped forever, even after reaching I2C_TIMEOUT_STOPF This commit fixes this issue

WARNING

This issue is present in multiple HAL driver repositories and processor CubeMX packages, and sometimes it has been fixed in the HAL driver repo but not yet in the CubeMX repo. This list is not exhaustive:

stm32h7xx_hal_driver
stm32u5xx_hal_driver
STM32CubeG4 but fixed in STM32G4xx_HAL_Driver

ALABSTM commented 1 year ago

ST Internal Reference: 128190

ALABSTM commented 1 year ago

Hi @paussems,

Thank you again for your proposal and please excuse our late reply. As this issue has been addressed in the frame of version 1.16.0 of this firmware, please allow me to close this pull-request.

Thank you for your comprehension and looking forward to receiving other contributions from you.

With regards,