search

STMicroelectronics / STM32CubeWB0

Full firmware for STM32WB0 series containing CMSIS, HAL-LL, BSP drivers, MW libraries, and a set of projects ready for use on STM32WB0 boards.
https://www.st.com/en/embedded-software/stm32cubewb0.html
Other
1 stars 0 forks source link

Rename driver files to follow usual STM32Cube convention #2

Closed erwango closed 1 week ago

erwango commented 2 weeks ago

Describe the bug

STM32WB0 driver files are named stm32wb0x_hal_adc.h while according to STM32Cube convention is stm32wb0xx_hal_adc.h (mind the double x). See for instance stm32wbaxx_hal_adc.h

Same for cmsis_device_wb0/Include files while aslo miss a x

Impact

Scripts based environments used to existing STM32Cube convention should add specific treatment for WB0.

msmttchr commented 2 weeks ago

Hello Erwan, is this something to be done by people who are releasing the Cube firmware? @orazioprivitera

erwango commented 2 weeks ago

Hello Erwan, is this something to be done by people who are releasing the Cube firmware? @orazioprivitera

I guess, yes.

TOUNSTM commented 2 weeks ago

ST Internal Reference: 189879

TOUNSTM commented 1 week ago

Hello @erwango,

We have received feedback from our development teams. Unfortunately, they have indicated that changing the driver/CMSIS naming convention at this stage would significantly impact backward compatibility and incur considerable effort. This change would need to be applied across the Cube SW package drivers, related documentation, and the STM32CubeMX tool integration.

Therefore, they suggest adapting the scripts to handle the single digit for STM32CubeWB0.

Thank you for your understanding. Best Regards,

erwango commented 1 week ago

Thanks for the feedback @TOUNSTM.

From what I understood there was also a good reason to make it this way as STM32WB0 variants use a single digit number (STM32WB07 for instance) while other series use 2 digits for variant naming (STM32WBA55 for instance). Hence this single x makes actual sense and it is not just a fantasy. We'll adapt our scripts to this possible use case.