STM32Cube MCU Full FW Package for the STM32WL series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on boards provided by ST (Nucleo boards)
LoRa-E5-STM32WLE5JC
GNU Arm Embedded Toolchain 10.3-2021.10
Suggestion:
Minor thing I noticed. In lora_info_template.c and all of the lora_info.c files in examples, part of loraInfo struct is uninitialized.
According to the struct declaration it has 4 members but when it is created it has only two first members set to zero:
static LoraInfo_t loraInfo = {0, 0};
However, all members are set to zero in Init function (I think the structure isn't accessed before this init). This makes my suggestion really cosmetic thing.
Setup:
LoRa-E5-STM32WLE5JC GNU Arm Embedded Toolchain 10.3-2021.10
Suggestion: Minor thing I noticed. In lora_info_template.c and all of the lora_info.c files in examples, part of
loraInfo
struct is uninitialized. According to the struct declaration it has 4 members but when it is created it has only two first members set to zero:static LoraInfo_t loraInfo = {0, 0};
However, all members are set to zero in Init function (I think the structure isn't accessed before this init). This makes my suggestion really cosmetic thing.
Solution:
static LoraInfo_t loraInfo = {0};