[LoRaMac]Optimize code reading and execution conditions and Add functions for use by the outer layer

STMicroelectronics / STM32CubeWL

STM32Cube MCU Full FW Package for the STM32WL series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on boards provided by ST (Nucleo boards)

Other

107 stars 54 forks source link

[LoRaMac]Optimize code reading and execution conditions and Add functions for use by the outer layer #84

Closed wdfk-prog closed 1 month ago

wdfk-prog commented 4 months ago

LoRaMacGetMaxPayloadLength

This function is provided for external use to obtain the maximum payload and can be used by the program to determine the number of bytes to send

LoRaMacSendInfoGet && LoRaMacSendInfoClear

In the application, the current used power and the remaining power are obtained by calculation. So it is necessary to know the number of lora packets and the time in the air

RJMSTM commented 4 months ago

Hello @wdfk-prog,

Please can you give some details about your pull request.

Regards,

wdfk-prog commented 4 months ago

Hello @wdfk-prog,

Please can you give some details about your pull request.

Regards,

As I read through the code, I noticed that it could be optimized; No further details could be provided

RJMSTM commented 4 months ago

ST Internal Reference: 180991

RJMSTM commented 4 months ago

Hello,

I forwarded your proposal to development team.

Regards,

wdfk-prog commented 4 months ago

Hello,

I forwarded your proposal to development team.

Regards,

I have updated some code, please check it out

RJMSTM commented 1 month ago

Hello @wdfk-prog,

Thanks for your contribution, With the proposed change, LORAMAC_EVENT_INFO_STATUS_OK would only be set if MacCtx.NodeAckRequested is false AND the device is not in class C. The existing implementation, however, also sets LORAMAC_EVENT_INFO_STATUS_OK if MacCtx.NodeAckRequested is false AND the device is in class C.

This modification would alter the execution flow; therefore, it cannot be accepted.

Regards,