search

STMicroelectronics / cmsis_device_f4

Provides the STM32Cube MCU Component "cmsis_device_f4" of the STM32F4 series.
Apache License 2.0
56 stars 24 forks source link

Typo in definition of __STM32F4xx_CMSIS_VERSION #6

Closed svijsv closed 2 years ago

svijsv commented 3 years ago

The definition of STM32F4xx_CMSIS_VERSION in stm32f4xx.h reads `#define STM32F4xx_CMSIS_VERSION ((STM32F4xx_CMSIS_VERSION_MAIN << 24)\ |(__STM32F4xx_CMSIS_VERSION_SUB1 << 16)\ |(STM32F4xx_CMSIS_VERSION_SUB2 << 8 )\ |(STM32F4xx_CMSIS_VERSION)) resulting in a compilation error when used. It should instead read #define STM32F4xx_CMSIS_VERSION ((STM32F4xx_CMSIS_VERSION_MAIN << 24)\ |(__STM32F4xx_CMSIS_VERSION_SUB1 << 16)\ |(STM32F4xx_CMSIS_VERSION_SUB2 << 8 )\ |(__STM32F4xx_CMSIS_VERSION_RC))`

ASELSTM commented 3 years ago

Hi @svijsv,

The issue you pointed out has been confirmed, a fix will be implemented and made available in future release. Thank you once again for your contribution.

With regards,

ASELSTM commented 3 years ago

ST Internal Reference: 110625

carlo-dev-git commented 2 years ago

I suggest to close this issue because it was fixed months ago. https://github.com/STMicroelectronics/cmsis_device_f4/blob/7ac69098b3e5f9b2d929acd4f087e92a7e59e0e9/Include/stm32f4xx.h#L110-L117

ASELSTM commented 2 years ago

Hi @svijsv,

As this issue has been fixed please allow me then to close this thread.

Thank you again for your contribution.

With regards,