search

STMicroelectronics / cmsis_device_h7

Provides the STM32Cube MCU Component "cmsis_device_h7" of the STM32H7 series.
Apache License 2.0
23 stars 15 forks source link

Incorrect __CM7_REV and some missing values in device headers #5

Closed billybednar closed 6 months ago

billybednar commented 1 year ago

Describe the set-up I'm reporting this for the STM32H742/743/750/753 family as I am most familiar with them, but it looks like this applies to all other H7 devices.

Describe the bug The __CM7_REV macro indicates that the revision of the M7 core is r1p0, but it's actually r1p1 according to the errata and the CPUID register on a physical device (0x411FC271). I imagine it's a carry over from older F7 devices. Making things more confusing, the datasheet and reference manual do not list the revision and old versions of the errata had a different incorrect value listed (r0p1).

https://github.com/STMicroelectronics/cmsis_device_h7/blob/v1.10.3/Include/stm32h742xx.h#L213

The headers also seem to be missing a few definitions (__VTOR_PRESENT, __FPU_DP, and __DTCM_PRESENT) that are present in the template from the included version of CMSIS.

https://github.com/ARM-software/CMSIS_5/blob/5.6.0/Device/_Template_Vendor/Vendor/Device/Include/Device.h#L101-L111

TOUNSTM commented 10 months ago

ST Internal Reference: 166097

TOUNSTM commented 6 months ago

Fixed in commit acfdbb7a81c43cb7106285da16ae6b9b2e4d879e