search

STOR-i / GaussianProcesses.jl

A Julia package for Gaussian Processes
https://stor-i.github.io/GaussianProcesses.jl/latest/
Other
308 stars 53 forks source link

Allow more recent version of StaticArrays and prepare for bugfix release #124

Closed andreasnoack closed 5 years ago

andreasnoack commented 5 years ago

The low upper bound on StaticArrays currently restricts us from using version 0.10 of this package.

andreasnoack commented 5 years ago

This currently breaks because of the new release of ZygoteRules. See https://github.com/JuliaRegistries/General/pull/5065

andreasnoack commented 5 years ago

Looks like this one is ready. You might want to look into the failure on nightly but I'm pretty sure the failure is unrelated to this PR.

andreasnoack commented 4 years ago

Would you be able to make a bugfix release? It would make it possible for us to use version 0.10 of your package.

fairbrot commented 4 years ago

I was about to increment the version but I am getting errors when running the unit tests on master related to the StaticArrays API. @andreasnoack did you already check this branch is working for you? If this isn't working, we will have to update how we are using StaticArrays in our source code before proceeding.

andreasnoack commented 4 years ago

Looks like tests are passing https://ci.appveyor.com/project/STOR-i/gaussianprocesses-jl. There is an issue on Julia nightly but that looks unrelated to StaticArrays.

fairbrot commented 4 years ago

I've looked into this some more and it turns out this that this error manifests itself StaticArrays@0.11.1 which is allowed by our Project.toml file (appveyor was testing using StaticArrays@0.12 which also works for me). Is there any reason we shouldn't just make v0.12 the minimum requirement? (@chris-nemeth @thomaspinder @jbrea )

chris-nemeth commented 4 years ago

It should be fine to make v0.12 the minimum, assuming that the tests pass.

maximerischard commented 4 years ago

I've removed support for the broken StaticArrays versions v0.10 and v0.11 (so v0.6, v0.9 and v0.12 are allowed) and tagged a new version.

andreasnoack commented 4 years ago

We'd appreciate if you could make new bugfix release that includes all the compat changes. In our project, we currently end up with version 0.9 of this package because of the missing versions in compat and that makes our Docker image significantly larger because of the very large notebooks in version 0.9. Thanks.

chris-nemeth commented 4 years ago

We've now updated the package with this patch.