STOR-i / GaussianProcesses.jl

A Julia package for Gaussian Processes
https://stor-i.github.io/GaussianProcesses.jl/latest/
Other
308 stars 53 forks source link

Update ScikitLearn.jl #154

Closed OkonSamuel closed 4 years ago

OkonSamuel commented 4 years ago

Hi, This PR fixes a bug in interface code to ScikitLearn.jl. see issue #149 for context. An alternative solution would be to make the definition of fit! less restrictive as

function fit!(gp::GPE, x::AbstractMatrix, y::AbstractVector)
    length(y) == size(x,2) || throw(ArgumentError("Input and output observations must have consistent dimensions."))
    gp.x = x
    gp.y = y
    gp.data = KernelData(gp.kernel, x, x, gp.covstrat)
    gp.cK = alloc_cK(gp.covstrat, length(y))
    gp.dim, gp.nobs = size(x)
    initialise_target!(gp)
end
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 430


Totals Coverage Status
Change from base Build 422: 0.0%
Covered Lines: 1468
Relevant Lines: 1962

💛 - Coveralls
chris-nemeth commented 4 years ago

Thanks for the PR!

OkonSamuel commented 4 years ago

@chris-nemeth. Thanks Could you please tag a new release

chris-nemeth commented 4 years ago

Sure. Will do.