Port-Group speed updates and Interface valid-speeds issue.

STORDIS / orca_nw_lib

gNMI python package for SONiC switch discovery and management.

Other

2 stars 3 forks source link

Port-Group speed updates and Interface valid-speeds issue. #67

Closed kamalkrbh closed 1 week ago

kamalkrbh commented 3 weeks ago

If port group speed is set to 25G , all interface in the port-group are updated to have the speed 25G, but the valid speeds and adv-speed set is still 1G and 10G which is not correct.

[x] The correct behaviour would be if port-group speed is updated, after receving the port-group update via gNMI subscription make an additional gnmi get to update the valid_speeds field for interface at sonic-port:sonic-port/PORT/PORT_LIST={interface_name}.
[x] Write test case for above.

kamalkrbh commented 2 weeks ago

@rahul-1475 , Perhaps discovering the Ethernets in the port groups might be an easy solution.

rahul-1475 commented 2 weeks ago

pull request links:

kamalkrbh commented 1 week ago

@rahul-1475 , Requested changes . Moving it to In Progress.

kamalkrbh commented 1 week ago

Moving to "Changes Requested Post Review" for better tracking.

kamalkrbh commented 1 week ago

@rahul-1475 , There are merge conflicts in both the PRs.