search

STORDIS / orca_ui

ORCA UI is a web application that provides a user interface for interacting with ORCA Backend. It is built using React. ORCA UI allows users to view the network topology, manage devices, and do various configurations.
https://stordis.github.io/
Apache License 2.0
4 stars 4 forks source link

Pressing esc key close the pop up. #144 #146

Closed vivek-metricdust closed 3 months ago

vivek-metricdust commented 4 months ago

fixes #144

on pressing esc key the popup models will be closed.

kamalkrbh commented 4 months ago

@vivek-metricdust ,Can we make base functioal component for all the forms, benifit of that would be Inheritance like property in functional compenents. Currently there are lots of common behaviours across various forms like handle submit, handle change, handle key down. And some of those behaviours are exactly same.

If we copy the behaviours in every form (or any other) component, there are high chances of some behavour missed and components will not remain uniform. Like all popup form can be closed by pressing escape but Dicovery form missed.

kamalkrbh commented 3 months ago

@vivek-metricdust, Getting following error while adding portchannel with out changing or entering any value in the form. Similar in mclag tab. image

kamalkrbh commented 3 months ago

@vivek-metricdust , while adding vlan without changing any value in the form : image

Also I see payload has a lots of empty values - image

vivek-metricdust commented 3 months ago

@kamalkrbh above mentioned issue are fixed and pushed

kamalkrbh commented 3 months ago

Still whle pressing esp on pop up for delete config option (on every tab), I see this - image