codecov[bot]
commented
2 years ago Codecov Report
Merging #1008 (751a088) into release-candidate (5b31a80) will increase coverage by
1.02%. The diff coverage is0.00%.
@@ Coverage Diff @@
## release-candidate #1008 +/- ##
=====================================================
+ Coverage 42.96% 43.99% +1.02%
=====================================================
Files 344 335 -9
Lines 22897 22364 -533
=====================================================
Hits 9838 9838
+ Misses 13059 12526 -533 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/Core/Animation/RotationCenterSkinning.cpp | 0.00% <0.00%> (ø) |
|
| src/Core/Containers/MakeShared.hpp | 100.00% <ø> (ø) |
|
| src/Core/Geometry/TopologicalMesh.cpp | 73.35% <0.00%> (+0.12%) |
:arrow_up: |
| src/Core/Geometry/TriangleMesh.inl | 80.62% <ø> (ø) |
|
| src/Engine/Scene/GeometryComponent.cpp | 3.44% <ø> (ø) |
|
| src/Engine/Scene/SkeletonComponent.hpp | 0.00% <ø> (ø) |
|
| src/Engine/Scene/SkinningComponent.cpp | 0.00% <ø> (ø) |
|
| src/Engine/Scene/SkinningComponent.hpp | 0.00% <ø> (ø) |
|
| ...keletonBasedAnimation/SkeletonBasedAnimationUI.cpp | 0.00% <ø> (ø) |
|
| src/Core/Utils/CircularIndex.inl | 0.00% <0.00%> (ø) |
|
| ... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
dlyr
nmellado
Pull Request Desription
Remove some dead code
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce? Cleaning and refactoring
What is the current behavior? (You can also link to an open issue here) Coverage is low and we can find a lot of dead code.
What is the new behavior (if this is a feature change)? Remove unused files + unconventional data structures and algorithms
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: