codecov[bot]
commented
2 years ago Codecov Report
Merging #1009 (d8ca0b0) into release-candidate (5b31a80) will decrease coverage by
0.01%. The diff coverage is0.00%.
@@ Coverage Diff @@
## release-candidate #1009 +/- ##
=====================================================
- Coverage 42.96% 42.94% -0.02%
=====================================================
Files 344 344
Lines 22897 22906 +9
=====================================================
Hits 9838 9838
- Misses 13059 13068 +9 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/Gui/RadiumWindow/SimpleWindowFactory.hpp | 0.00% <0.00%> (ø) |
|
| src/Gui/Viewer/Viewer.cpp | 0.00% <0.00%> (ø) |
|
| src/Gui/Viewer/Viewer.hpp | 0.00% <ø> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pull Request Description
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here) GizmoManager is automatically created by viewer.
What is the new behavior (if this is a feature change)? GizmoManager is created only on request.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) YES. GizmoManager is no longer generated by default in Viewer. In current version:
SimpleWindowFactorynow has an option (preset to true) to request the generation of the GizmoManager.SimpleWindowdoes not have this behavior, as it is a Minimal Radium Window (according to documentation), I though the GIzmoManager is not part of the minimal set of functionalities.These choices can be discussed.