STORM-IRIT / Radium-Engine

Research 3D Engine for rendering, animation and processing
https://storm-irit.github.io/Radium-Engine/
Apache License 2.0
100 stars 50 forks source link

Core variables #1022

Closed MathiasPaulin closed 1 year ago

MathiasPaulin commented 1 year ago

Pull Request Description

First proposal to integrate into Core the management of "variables" from all other components. A "variable is a mapping between a name and a type to a value.

The intent of this PR is to replace the class ("had-hoc and heavily specialized) RenderParameter to have the opportunity to manage several other variable representation and to simplify the extension of such renderParameter.

TODO

codecov[bot] commented 1 year ago

Codecov Report

Merging #1022 (d4812cd) into release-candidate (69323dc) will increase coverage by 1.07%. The diff coverage is 78.85%.

:exclamation: Current head d4812cd differs from pull request most recent head 4eba76d. Consider uploading reports for the commit 4eba76d to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1022      +/-   ##
=====================================================
+ Coverage              44.52%   45.59%   +1.07%     
=====================================================
  Files                    337      341       +4     
  Lines                  22486    22975     +489     
=====================================================
+ Hits                   10011    10475     +464     
- Misses                 12475    12500      +25     
Impacted Files Coverage Δ
src/Engine/RadiumEngine.hpp 100.00% <ø> (ø)
src/Gui/Viewer/CameraManipulator.hpp 0.00% <ø> (ø)
src/Gui/Viewer/FlightCameraManipulator.cpp 0.00% <0.00%> (ø)
src/Gui/Viewer/Gizmo/GizmoManager.cpp 0.00% <ø> (ø)
src/Gui/Viewer/RotateAroundCameraManipulator.cpp 0.00% <ø> (ø)
src/Gui/Viewer/TrackballCameraManipulator.cpp 0.00% <0.00%> (ø)
src/Gui/Viewer/Viewer.cpp 0.00% <0.00%> (ø)
src/Gui/Viewer/Viewer.hpp 0.00% <ø> (ø)
src/Gui/Utils/KeyMappingManager.inl 26.92% <26.92%> (ø)
src/Core/Tasks/TaskQueue.cpp 81.00% <71.42%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.