Closed dlyr closed 2 years ago
Merging #1024 (69323dc) into release-candidate (af38ec3) will increase coverage by
0.00%
. The diff coverage is71.42%
.:exclamation: Current head 69323dc differs from pull request most recent head e0e6203. Consider uploading reports for the commit e0e6203 to get more accurate results
@@ Coverage Diff @@
## release-candidate #1024 +/- ##
==================================================
Coverage 44.51% 44.52%
==================================================
Files 337 337
Lines 22477 22486 +9
==================================================
+ Hits 10006 10011 +5
- Misses 12471 12475 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/Engine/RadiumEngine.hpp | 100.00% <ø> (ø) |
|
src/Core/Tasks/TaskQueue.cpp | 81.00% <71.42%> (-1.35%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
It's ok for me, no segmentation fault detected on my linux machine.
The CI jobs was cancelled on macOS, how to get these jobs going again ?
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here) There is a concurrency problem in task queue, when worker idle wainting for task, they can steal task from runTaskInThisThread. Moreover, if registerTask is not renetrant, and can cause task incoherency if task are added to one queue from different threads. Fix #1023