STORM-IRIT / Radium-Engine

Research 3D Engine for rendering, animation and processing
https://storm-irit.github.io/Radium-Engine/
Apache License 2.0
100 stars 50 forks source link

Fix #1023 #1024

Closed dlyr closed 2 years ago

dlyr commented 2 years ago

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1024 (69323dc) into release-candidate (af38ec3) will increase coverage by 0.00%. The diff coverage is 71.42%.

:exclamation: Current head 69323dc differs from pull request most recent head e0e6203. Consider uploading reports for the commit e0e6203 to get more accurate results

@@                Coverage Diff                 @@
##           release-candidate    #1024   +/-   ##
==================================================
  Coverage              44.51%   44.52%           
==================================================
  Files                    337      337           
  Lines                  22477    22486    +9     
==================================================
+ Hits                   10006    10011    +5     
- Misses                 12471    12475    +4     
Impacted Files Coverage Δ
src/Engine/RadiumEngine.hpp 100.00% <ø> (ø)
src/Core/Tasks/TaskQueue.cpp 81.00% <71.42%> (-1.35%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hiergaut commented 2 years ago

It's ok for me, no segmentation fault detected on my linux machine.

hiergaut commented 2 years ago

The CI jobs was cancelled on macOS, how to get these jobs going again ?