Fix Core::VariableSet

[MathiasPaulin]

Pull Request Desription

Fix remaining bugs in VariableSet

• missing erased on moved containers
• dynamic visitor segfault

Add the ability to pass user parameter to visitors.

Improve documentation

Question, do we extend the capabilities of VariableSet::TypeList to have something like https://github.com/AcademySoftwareFoundation/openvdb/blob/master/openvdb/openvdb/TypeList.h

Check if you branch history is PR compatible

• Your branch need to be up to date with origin/master AND to have linear history (i.e. no merge commit).
• Update your git repository git fetch origin if origin is this remote
• Check with the script provided in scripts/is-history-pr-compatible.sh
• You must use clang-format style These checks are enforced by github workflow actions Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

• [x] The commit message follows our guidelines
• [x] Tests for the changes have been added (for bug fixes / features)
• [x] Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

• What kind of change does this PR introduce?

  • [x] bug fix
  • [ ] feature
  • [ ] docs update
  • [ ] other:

• What is the current behavior? (You can also link to an open issue here)

  • Moved container are not in a proper state
  • Some lambda capture references that have shorter lifetime than the lambda

• What is the new behavior (if this is a feature change)?

  • all is fixed

[codecov[bot]]

Codecov Report

Merging #1033 (a4fbe8b) into release-candidate (08428a6) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Current head a4fbe8b differs from pull request most recent head d2e43bd. Consider uploading reports for the commit d2e43bd to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1033      +/-   ##
=====================================================
+ Coverage              45.61%   45.68%   +0.07%     
=====================================================
  Files                    343      343              
  Lines                  23100    23133      +33     
=====================================================
+ Hits                   10536    10569      +33     
  Misses                 12564    12564              

Impacted Files	Coverage Δ
src/Core/Containers/VariableSet.cpp	100.00% <100.00%> (ø)
src/Core/Containers/VariableSet.hpp	100.00% <100.00%> (ø)
tests/unittest/Core/variableset.cpp	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.