Closed dlyr closed 1 year ago
Merging #1034 (8359ab4) into release-candidate (8aa0b1b) will decrease coverage by
0.10%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## release-candidate #1034 +/- ##
=====================================================
- Coverage 45.68% 45.59% -0.10%
=====================================================
Files 343 343
Lines 23133 23180 +47
=====================================================
Hits 10569 10569
- Misses 12564 12611 +47
Impacted Files | Coverage Δ | |
---|---|---|
src/Gui/Viewer/CameraManipulator.hpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/FlightCameraManipulator.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/RotateAroundCameraManipulator.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/TrackballCameraManipulator.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/Viewer.cpp | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pull Request Desription
Fix camera manipulators wrt KeyMapping callbacks.
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
RotateAround was broken since it derives from Trackball, and m_currentAction was out of sync since the use of callback to manager action.
Handle all camera manipulators with callback associated to action.
Also add camera manipulator switch in draw primitive demo, to check the three provided camera manipulator.
For futur PR, maybe remove FlightManipulatorContext, move KeyMappingContext to CameraManipulator, and then #545