STORM-IRIT / Radium-Engine

Research 3D Engine for rendering, animation and processing
https://storm-irit.github.io/Radium-Engine/
Apache License 2.0
100 stars 50 forks source link

Remove inlines #1037

Closed dlyr closed 1 year ago

dlyr commented 1 year ago

Remove #include "foo.inl" from foo.hpp and replace it by the inl content, using noinl.py script, run from src/ directory.

Also remove inline references from CMakeLists.txt and scripts.

If new pushes on release-candidate, skip commit run noinl.py and remove inl to redo it on a clean basis (e.g. run the script and git rm inl files)

TODO

codecov[bot] commented 1 year ago

Codecov Report

Merging #1037 (1b99c70) into release-candidate (7fdb8bb) will decrease coverage by 0.14%. The diff coverage is 62.31%.

:exclamation: Current head 1b99c70 differs from pull request most recent head 0eafdad. Consider uploading reports for the commit 0eafdad to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1037      +/-   ##
=====================================================
- Coverage              45.74%   45.61%   -0.14%     
=====================================================
  Files                    339      312      -27     
  Lines                  23279    23085     -194     
=====================================================
- Hits                   10649    10530     -119     
+ Misses                 12630    12555      -75     
Impacted Files Coverage Δ
src/Core/Animation/HandleArray.hpp 0.00% <0.00%> (ø)
src/Core/Asset/AnimationData.hpp 0.00% <0.00%> (ø)
src/Core/Geometry/MeshPrimitives.hpp 0.00% <0.00%> (ø)
src/Core/Geometry/OpenMesh.hpp 0.00% <0.00%> (ø)
src/Core/Geometry/Spline.hpp 0.00% <0.00%> (ø)
src/Core/Geometry/deprecated/TopologicalMesh.hpp 0.00% <0.00%> (ø)
src/Core/Utils/CircularIndex.hpp 0.00% <0.00%> (ø)
src/Engine/Data/RawShaderMaterial.cpp 0.00% <ø> (ø)
src/Engine/Data/RawShaderMaterial.hpp 0.00% <0.00%> (ø)
src/Engine/Data/VolumeObject.hpp 0.00% <0.00%> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.