Closed dlyr closed 1 year ago
I'll propose a fix soon.
Merging #1040 (5dd6951) into release-candidate (2ae32cd) will decrease coverage by
0.05%
. The diff coverage is0.00%
.:exclamation: Current head 5dd6951 differs from pull request most recent head 8580efa. Consider uploading reports for the commit 8580efa to get more accurate results
@@ Coverage Diff @@
## release-candidate #1040 +/- ##
=====================================================
- Coverage 45.71% 45.66% -0.05%
=====================================================
Files 343 343
Lines 23251 23276 +25
=====================================================
Hits 10630 10630
- Misses 12621 12646 +25
Impacted Files | Coverage Δ | |
---|---|---|
src/Gui/Viewer/RotateAroundCameraManipulator.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/Viewer.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/Viewer.hpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/WindowQt.cpp | 0.00% <0.00%> (ø) |
|
src/Gui/Viewer/WindowQt.hpp | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Pull Request Desription
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
see #1039
What is the new behavior (if this is a feature change)?
Takes into account device pixel ratio on any system so that OpenGL rendering and picking works with device (physical) coordinates. tested on :
Event management not related to openGL rendering still remains based on Qt logical coordinates.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Gizmo manipulation computations remain in logical coordinate, even if the openGL part of the Gizmos relies on physical coordinates.
The "scale" of the display (and then the devicePixelRatio) could be changed dynamically, without restarting the app. If two displays with different dpi are used, moving the app from one display to the other also get the right devicePixelRatio.