STORM-IRIT / Radium-Engine

Research 3D Engine for rendering, animation and processing
https://storm-irit.github.io/Radium-Engine/
Apache License 2.0
100 stars 50 forks source link

[headless] Fix camera possible leak. #1073

Closed dlyr closed 1 year ago

dlyr commented 1 year ago

Pull Request Desription

Please check if the PR fulfills these requirements

PR details

Neked new is used for camera in CLI viewer, use unique_ptr instead. Also fix 0 thread queue.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1073 (2e6efd4) into release-candidate (54aef71) will decrease coverage by 0.02%. Report is 1 commits behind head on release-candidate. The diff coverage is 25.00%.

:exclamation: Current head 2e6efd4 differs from pull request most recent head fb66f6a. Consider uploading reports for the commit fb66f6a to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1073      +/-   ##
=====================================================
- Coverage              45.72%   45.71%   -0.02%     
=====================================================
  Files                    312      312              
  Lines                  23096    23106      +10     
=====================================================
+ Hits                   10561    10563       +2     
- Misses                 12535    12543       +8     
Files Coverage Δ
src/Headless/CLIViewer.hpp 100.00% <ø> (ø)
src/Headless/CLIViewer.cpp 53.17% <25.00%> (-2.86%) :arrow_down: