Closed dlyr closed 2 years ago
Merging #990 (c0bc4e3) into release-candidate (5454120) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## release-candidate #990 +/- ##
==================================================
Coverage 39.93% 39.93%
==================================================
Files 345 345
Lines 22928 22928
==================================================
Hits 9157 9157
Misses 13771 13771
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
On my install, when I run bash ./generateFilelistForModule.sh Gui
it works, since it uses bash from homebrew install (version 5.x)
I'm fine with your proposal, maybe we can switch this kind of script in python or js to avoid such portability issues.
On my install, when I run
bash ./generateFilelistForModule.sh Gui
it works, since it uses bash from homebrew install (version 5.x)
Sure, it works also on mine using the macport installed version of bash (version 5.x). But neither macport nor homebrew replace /bin/bash. So, executing the script with just ./generateFilelistForModule.sh Gui
still not work.
I'm fine with your proposal, maybe we can switch this kind of script in python or js to avoid such portability issues.
I agree with this, but I am not able to do it, my skills in python or js are way too low
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Try to fix generate filelist script on macos x
What is the current behavior? (You can also link to an open issue here) find command print a // if the argument have a trailing /
this pr should fix it.