search

STRML / Imgur-to-Gfycat

Chrome extension that replaces gifs hosted by imgur to HTML5-optimized video converted and hosted by gfycat.
23 stars 5 forks source link

YouTube thumbnails and comments completely fail to load when enabled. #1

Closed nelsonjchen closed 10 years ago

nelsonjchen commented 10 years ago

Anyone else seeing this issue? When this extension is disabled, YouTube thumbnails and comments load again.

STRML commented 10 years ago

Sorry, I can't replicate this. I can only posit that it might be related to this line that blocks imgur gif loading when it's unnecessary, but it only runs on imgur urls. Could you take a look at your web inspector when you're seeing the bug and see if any requests are failing?

nelsonjchen commented 10 years ago

I'll take a closer look when I get out from work. It could be a degenerate combination of extensions I have. Web inspector doesn't seem to bitch too much but I only looked at the page context and not any of the extensions. If so, I'll get back to you with that when I figure that out.

Oh, no requests are failing. It's more like as if Javascript barfed (the thumbnail urls are in data attributes). Anyway, more info to come.

nelsonjchen commented 10 years ago

Ugh, a cursory look at the console shows a count of warnings popping up in the console increasing but the console has no output from the page or the extension. I'll try to reproduce in Canary.

nelsonjchen commented 10 years ago

I can reproduce this issue in Canary. OS X 10.9. I own a Retina Macbook so I launched it in low-res and high-res. Same results.

I can reproduce this issue in two Sauce Labs VMs/instances. Windows 7/Chrome 31. Linux/Chrome 30.

For all of the these installations, I installed the extension from the webstore. Video thumbnails appear as grey rectangles and comments fail to load on youtube.com.

STRML commented 10 years ago

Thanks. That should be enough to go on. Thanks for spending the time to reproduce it. On Jan 3, 2014 11:09 PM, "Nelson Chen" notifications@github.com wrote:

I can reproduce this issue in Canary. OS X 10.9. I own a Retina Macbook so I launched it in low-res and high-res. Same results.

I can reproduce this issue in two Sauce Labs VMs/instances. Windows 7/Chrome 31. Linux/Chrome 30.

For all of the these installations, I installed the extension from the webstore. Video thumbnails appear as grey rectangles and comments fail to load on youtube.com.

— Reply to this email directly or view it on GitHubhttps://github.com/STRML/Imgur-to-Gfycat/issues/1#issuecomment-31570933 .

STRML commented 10 years ago

I went ahead and spun up a saucelabs VM (nice service!) to see if I could reproduce this exactly; unfortunately, I can't:

Imgur

I installed from the webstore and opened up a youtube link from their main page. Tried out a bunch of them, no issue.

Sorry for the hassle but I can't fix it if I can't see it - and looking at the code, I can't see any way that it could be causing these issues. There is a hook into the WebRequests API but it is specifically set to only run on imgur domains.

STRML commented 10 years ago

Could you see if you can replicate this with the latest version v1.1.3?

It's in the process of publishing to the web store now (takes about 60m) so you can use the crx in the root directory of this project if you catch this in the next hour.

nelsonjchen commented 10 years ago

So freaking weird. I'll try the crx but the sauce labs VM not reproducing the issue is like some GITS's laughing man bullshit.

nelsonjchen commented 10 years ago

Anyway, v1.1.3 appears to fix the issue. Thanks for looking into it.

STRML commented 10 years ago

Fantastic! If you or anyone else sees this issue again, please comment on this issue.