search

STRML / react-router-component

Declarative router component for React.
http://strml.viewdocs.io/react-router-component
MIT License
873 stars 94 forks source link

Hash Routing and React 15 issue fix #181

Closed BlakeRxxk closed 7 years ago

BlakeRxxk commented 7 years ago

fix Warning: Unknown prop with _, _query and hash in 0.36.0 and react in version 15.3.2

ref https://github.com/STRML/react-router-component/issues/178

STRML commented 7 years ago

I don't think this is #178 - you have specifically removed _query on the <Link> element, but <Link> should never be receiving it.

BlakeRxxk commented 7 years ago

right, _query isn't part of #178 issue, but I've noticed react warning in tests

nilsml commented 7 years ago

Is this fix being merged in? Still receiving the warning Unknown prop 'hash' on <div> tag when using 0.36.4.

BlakeRxxk commented 7 years ago

I can resolve conflict, but need approval of @STRML

STRML commented 7 years ago

@nilsml This won't fix the unknown prop hash error.

@BlakeRxxk I am still not sure what this fixes. _query should never be received by <Link>.

BlakeRxxk commented 7 years ago

@STRML as i mentioned before - running tests throws Unknown prop _query ... so i decided to add small fix.

otherwise without _query fixes it still remove Unknown prop 'hash' on <div> tag error

STRML commented 7 years ago

Aha. I had forgotten we introspect propTypes for the omit lists.

I've adapted this in 6500944 and will release shortly. Thanks @BlakeRxxk.