search

STRML / react-router-component

Declarative router component for React.
http://strml.viewdocs.io/react-router-component
MIT License
874 stars 94 forks source link

ensure joined routes are slash separated #205

Closed jsg2021 closed 6 years ago

jsg2021 commented 6 years ago

The active route may not have a slash at the end, yet if we call makeHref() or navigate() with a deeper segment, the route change fails.

STRML commented 6 years ago

Good idea, could you add a test for this?

jsg2021 commented 6 years ago

yes, i’ll try to add one in the morning. On Tue, Mar 13, 2018 at 7:05 PM Samuel Reed notifications@github.com wrote:

Good idea, could you add a test for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/STRML/react-router-component/pull/205#issuecomment-372860683, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjPrQoS6bJSvjEjzlRxwe8mOVf6sYWYks5teF7SgaJpZM4SpkNP .

jsg2021 commented 6 years ago

Test added. :)

jsg2021 commented 6 years ago

Can this be published to npm?