search

STRML / textFit

A jQuery-free component that quickly fits single and multi-line text to the width (and optionally height) of its container.
https://textfit.strml.net
642 stars 122 forks source link

accept string as well #48

Closed thewayur closed 3 years ago

thewayur commented 3 years ago

right now it accepts element i.e. $('.box') or document.getElementsByClassName('box')

please allow us to pass the string directly with box class

thank you

thewayur commented 3 years ago

also please RETURN the inline style.

STRML commented 3 years ago

Why? You can trivially do this in your own code.

If you can do in a PR minimally and make a good case for it I may consider but otherwise this doesn't look like a good use of time.

On Wed, May 12, 2021 at 6:57 AM thewayur @.***> wrote:

also please RETURN the inline style.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/STRML/textFit/issues/48#issuecomment-839677947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJEKP7LKA5XJ5D6WPVTS6TTNJNJZANCNFSM44YK7PTA .

thewayur commented 3 years ago

Why? You can trivially do this in your own code. If you can do in a PR minimally and make a good case for it I may consider but otherwise this doesn't look like a good use of time. … On Wed, May 12, 2021 at 6:57 AM thewayur @.***> wrote: also please RETURN the inline style. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#48 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJEKP7LKA5XJ5D6WPVTS6TTNJNJZANCNFSM44YK7PTA .

i did it without hassle, well sorry to bother you! just trying to add some functionality, atleast returning something from function wont harm the code :)

anyway, thanks for this useful library, i m loving it :)