Replace scrollHeight/width with getBoundingClientRect

STRML / textFit

A jQuery-free component that quickly fits single and multi-line text to the width (and optionally height) of its container.

https://textfit.strml.net

637 stars 123 forks source link

Replace scrollHeight/width with getBoundingClientRect #50

Closed Mat-thieu closed 3 years ago

Mat-thieu commented 3 years ago

The PR following the issue mentioned in #49 I noticed PR #18 actually changed these to scrollHeight, but I was not able to recreate the issue he has mentioned using the changes made in this PR https://jsfiddle.net/thieu95/356gcqb2/2/ was an attempt

STRML commented 3 years ago

Will spend some time reviewing & pinged the author of #18.

STRML commented 3 years ago

Looks good, thanks!