search

STRRL / cloudflare-tunnel-ingress-controller

🚀 Expose the website directly into the internet! The Kuberntes Ingress Controller based on Cloudflare Tunnel.
MIT License
655 stars 39 forks source link

Feature request: Add ServiceMonitor #127

Open z0rc opened 2 weeks ago

z0rc commented 2 weeks ago

In many cases prom configuration is managed by prometheus-operator, which uses ServiceMonitor custom resources to setup prom scraping targets.

Please add ability to deploy ServiceMonitor as part of helm chart.

Important thing to keep in mind. When ServiceMonitor is enabled, Service must not have prometheus scraping annotations set. As this may cause double scrape in some configurations.

STRRL commented 2 weeks ago

That sounds great! Thanks!

Do you have interest in coding it? Or would I write the code and invite you to make a review? Which one do you prefer?

z0rc commented 1 week ago

Yeah, I can submit a PR for this.

STRRL commented 1 week ago

Yeah, I can submit a PR for this.

That's great! Thanks a lot! ❤️ 🚀