Closed bcaldwell closed 10 months ago
Merging #50 (382ab84) into master (95c265e) will decrease coverage by
0.21%
. The diff coverage is0.00%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 26.20% 25.99% -0.21%
==========================================
Files 9 9
Lines 622 627 +5
==========================================
Hits 163 163
- Misses 449 454 +5
Partials 10 10
Files | Coverage Δ | |
---|---|---|
pkg/controller/ingress-controller.go | 0.00% <0.00%> (ø) |
@STRRL can you please check it out and release new version?
Thanks! @bcaldwell
Thank you for writing this project. I ran into an issue when running this project in my cluster with 2 ingresses (an existing ingress class for nginx, and this one):
It seemed to consider the ingress configuration no matter which ingress class I had set on the ingress object, which meant it tried to configure all the ingresses including the ones nginx was managing. This PR prevents that by filtering the controlled ingress classes to the ones that match the set controller class name.