Closed UnstoppableMango closed 5 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
c685e37
) 25.91% compared to head (c7ed1c5
) 26.48%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/controller/transform.go | 76.92% | 2 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PTAL @UnstoppableMango, I would very much appreciate it if you could address these changes. 🥰🥰
You got it! That first one is a little embarrassing 😳 should be able to make the updates this afternoon!
Ach I apoligize that first attempt was really half-baked!
I didn't see a great spot to move tests to, is there a place you think they should live?
Should resolve #68
A note about the implementation, I wasn't a fan of mutating theService
inside ofFromIngressToExposure
but it was the most convenient place for it right now. I could move the mutation into the reconcile method directly, but then we would need a redundantclient.Get()
call. We could move it somewhere else as well, but that would probably require a bit of refactoring.