STRRL / cloudflare-tunnel-ingress-controller

🚀 Expose the website directly into the internet! The Kuberntes Ingress Controller based on Cloudflare Tunnel.
MIT License
644 stars 37 forks source link

Duplicate records repeatedly added to Ingress.status.loadBalancer.ingress #88

Closed giovannimatina closed 4 months ago

giovannimatina commented 4 months ago

Since I updated the controller to version 0.0.10, I've noticed an anomalous behavior. Every time the controller iterates, new duplicate records are added to the ingress list within the loadBalancer field of the status. This behavior is leading to a continuous accumulation of duplicates, compromising the integrity and usefulness of the status.

Example of the issue:

status:
  loadBalancer:
    ingress:
    - hostname: example-uuid.cfargotunnel.com
      ports:
      - port: 443
        protocol: TCP
    - hostname: example-uuid.cfargotunnel.com
      ports:
      - port: 443
        protocol: TCP
    - hostname: example-uuid.cfargotunnel.com
      ports:
      - port: 443
        protocol: TCP
...
UnstoppableMango commented 4 months ago

I think I may have introduced this recently 😬 hopefully #89 should resolve it! The implementation I went with will only prevent future duplicates, I have an open question on whether its worthwhile to check and remove duplicates.

STRRL commented 4 months ago

Hi @giovannimatina @UnstoppableMango , thanks for your reporting and contribution! We are working on this!