STScI-Citizen-Science / MTPipeline

Pipeline to produce CR rejected, astrodrizzled, png's of HST WFPC2 solar system data.
6 stars 1 forks source link

Merging revise_PNG into Master #144

Closed ktfhale closed 10 years ago

ktfhale commented 10 years ago

Now that all of our images (with 83 known bad exceptions) have preview images, and we've preserved a version of our pipeline that still retains CosmoQuest functionality, I think it's time to merge this branch into Master.

The development process for this branch is documented in Ticket #129. In summary, this branch introduces the following major changes:

We output both a linear and log stretch in order to insure that at least one preview image is useful for each AstroDrizzle output. In general, linear stretching works for planetary targets, and log stretching works for fainter fields. Certain exceptions to this rule (not infrequently due to WFC3/UVIS often having a row of border pixels with absurd values) make creating a single, one-size-fits-all stretch very challenging. See the last few comments in Ticket #129 for details.

acviana commented 10 years ago

So, are these files now in the state you want?

ktfhale commented 10 years ago

Yes, they are. Sorry, that was a comment to a line in the second-to-last commit. The latest commit fixes the problem. I didn't expect it to put the comment in the pull request. To my knowledge, everything's in the state I want.

acviana commented 10 years ago

Cool, as an educational aside, if we were doing this right we should "squash" our commits. This reduces all the work in the branch into a single commit and removes the intermediate commit points that we would never want to revert to. But in practice we haven't been doing this so there really isn't motivation to do that now.