search

STeng618 / pe

0 stars 0 forks source link

Input strings with ; #2

Open STeng618 opened 2 months ago

STeng618 commented 2 months ago

Insert a calorie item with description chicken ; rice ; No error raised at insertion

Screenshot 2024-04-19 at 4.29.51 PM.png

However, the line is flagged as an error upon relaunch

Screenshot 2024-04-19 at 4.30.33 PM.png

Input strings with ; are not uncommon

nus-pe-script commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error is not purged

Add a calorie item with description chicken;

Quit the application.

Launch the application, an error is flagged.

Quit the application again.

Launch the application again, the same error is flagged.

Implication: users have to manually remove the corrupted entry from the data file

[original: nus-cs2113-AY2324S2/pe-interim#1853] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi there, thank you for the bug report!

We agree with you that this error was not handled, however we feel that the severity of this bug is low because the semi colon is hardly used. Furthermore, we feel that entering semi colons for calories description occurs only in very rare occasions.

image.png

Thank you!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This bug is due to improper handling of inputs with semicolons. Inputs with semicolons are accepted at first but flagged as errors upon relaunch.

The "original" bug is due to the application not purging corrupted entries from the data files, relying on the users to manually remove corrupted entries from the data files.

Resolving the issues with not purging corrupted data entries will not fix the bug that the application misjudges inputs with semicolons as valid but flags them as errors during file parsing.

The developers probably marked them as duplicates because both issues were due to the use of semicolons in user input, but they clearly point to different flaws with the application design and are unrelated.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]