search

STeng618 / pe

0 stars 0 forks source link

Different error messages for large integers #9

Open STeng618 opened 2 months ago

STeng618 commented 2 months ago

Screenshot 2024-04-19 at 5.07.16 PM.png

nus-se-script commented 2 months ago

Team's Response

Hi, thanks for this issue. We have updated this as a feature flaw because it is an "error" in the exception messages instead.

However our team intentionally put different error messages for the large integers because there are 2 cases

  1. Invalid index where index we chose is not in the sleep list
  2. Index is out of bounds, meaning over integer limit, hence it is not a valid index

Our team feels that the messages above makes sense because sleep delete 3 falls under case 1, and sleep delete 123......... falls under index out of bounds.

Also, our team feels that regardless of what the message is outputting, it is quite intuitive for the user to understand that a wrong index has been keyed in. Thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]