SU-SWS / decanter

A collection of front end web resources.

GNU General Public License v3.0

41 stars 9 forks source link

ADAPT-000: Add options to fontSize.js for the modular scale steps #805

Closed yvonnetangsu closed 3 years ago

yvonnetangsu commented 3 years ago

READY FOR REVIEW

Summary

Added steps in fontSize.js utility which correspond to decanter 6's @modular-typography mixin. It purely sets the font size using the modular scale of 1.25 ratio and responsive variants are generated. This allows for eg, su-text-m0 md:su-text-m1 2xl:su-text-m3 (step 0 = 1em for mobile, step 1 = 1.25em for MD, step 3 = 1.95em for 2XL).

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Looks at code and see that the new font size classes are being generated.

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist

sherakama commented 3 years ago

I'm going to need to bring bump to this repo as well. I'll put that on my todo