cjwest commented 3 years ago

READY FOR Review

What do you think of this approach? Any suggestions or changes?

Summary

This adds pull-quote functionality

Needed By (Date)

Urgency

not urgent

Steps to Test

Add html to text area
Verify the pull quotes display as expected

  <h2>Pull-quote</h2> 

  <p>Fusce a quam. Nunc nec neque. In consectetuer turpis ut velit. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Nunc interdum lacus sit amet orci.</p>

<aside class="su-pull-quote--left">
<p>This is the first paragraph of pull-quote text. Pellentesque dapibus hendrerit tortor. Nullam quis ante. Proin viverra, ligula sit amet ultrices semper, ligula arcu tristique sapien, a accumsan nisi mauris ac eros.</p>
<p>This is the second paragraph pull-content text. Pellentesque dapibus hendrerit tortor. Nullam quis ante. Proin viverra, ligula sit amet ultrices semper, ligula arcu tristique sapien, a accumsan nisi mauris ac eros.</p>
</aside>

<p>Maecenas tempus, tellus eget condimentum rhoncus, sem quam semper libero, sit amet adipiscing sem neque sed ipsum. Etiam sollicitudin, ipsum eu pulvinar rutrum, tellus ipsum laoreet sapien, quis venenatis ante odio sit amet eros.</p>

<p>Praesent ac massa at ligula laoreet iaculis. Phasellus dolor. Proin faucibus arcu quis ante. Donec sodales sagittis magna. Nullam accumsan lorem in dui.</p>

<p>In dui magna, posuere eget, vestibulum et, tempor auctor, justo. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Suspendisse nisl elit, rhoncus eget, elementum ac, condimentum eget, diam. Curabitur blandit mollis lacus. Morbi mattis ullamcorper velit.</p>

<p>Donec id justo. Nullam nulla eros, ultricies sit amet, nonummy id, imperdiet feugiat, pede. Donec pede justo, fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Aenean imperdiet.</p>
 <p>Fusce a quam. Nunc nec neque. In consectetuer turpis ut velit. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Nunc interdum lacus sit amet orci.</p>

<aside class="su-pull-quote--right">
<p>This is the first paragraph of pull-quote text. Pellentesque dapibus hendrerit tortor. Nullam quis ante. Proin viverra, ligula sit amet ultrices semper, ligula arcu tristique sapien, a accumsan nisi mauris ac eros.</p>
<p>This is the second paragraph pull-content text. Pellentesque dapibus hendrerit tortor. Nullam quis ante. Proin viverra, ligula sit amet ultrices semper, ligula arcu tristique sapien, a accumsan nisi mauris ac eros.</p>
</aside>

<p>Maecenas tempus, tellus eget condimentum rhoncus, sem quam semper libero, sit amet adipiscing sem neque sed ipsum. Etiam sollicitudin, ipsum eu pulvinar rutrum, tellus ipsum laoreet sapien, quis venenatis ante odio sit amet eros.</p>

<p>Praesent ac massa at ligula laoreet iaculis. Phasellus dolor. Proin faucibus arcu quis ante. Donec sodales sagittis magna. Nullam accumsan lorem in dui.</p>

<p>In dui magna, posuere eget, vestibulum et, tempor auctor, justo. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Suspendisse nisl elit, rhoncus eget, elementum ac, condimentum eget, diam. Curabitur blandit mollis lacus. Morbi mattis ullamcorper velit.</p>

<p>Donec id justo. Nullam nulla eros, ultricies sit amet, nonummy id, imperdiet feugiat, pede. Donec pede justo, fringilla vel, aliquet nec, vulputate eget, arcu. In enim justo, rhoncus ut, imperdiet a, venenatis vitae, justo. Aenean imperdiet.</p>

</div>

Affected Projects or Products

Associated Issues and/or People

JIRA ticket HAIWR-266
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

@cjwest Thank you for the revision - I think the class approach is great. If we want to add this as a component, then we'll need the twig template and sample json data as well, but before you do more work on this - let's get a designer to look at this :) I think Kerri is totally booked at the moment though 🤔

cjwest commented 3 years ago

@cjwest Thank you for the revision - I think the class approach is great. If we want to add this as a component, then we'll need the twig template and sample json data as well, but before you do more work on this - let's get a designer to look at this :) I think Kerri is totally booked at the moment though 🤔

Thanks for bringing that up, @yvonnetangsu! I've only seen it used as classes within the WYSIWYG (think "splash text"), and no twig templated was needed. I could use your help in envisioning how a twig template and sample json would be used.

yvonnetangsu commented 3 years ago

@kerri-augenstein When you have time, let's take a look at this component that Caryl is working on and see if it needs any design tweaks to go into Decanter 😄