SU-SWS / decanter

A collection of front end web resources.

GNU General Public License v3.0

41 stars 9 forks source link

ADAPT-578: modified <a> text color for Info, Success and default Alerts #817

Closed andrewbaraniuk closed 3 years ago

andrewbaraniuk commented 3 years ago

READY FOR REVIEW

(Edit the above to reflect status)

Summary

Fixes text color for the default Alert which currently looks like this - https://www.awesomescreenshot.com/image/7155716?key=68fb201780bf975cafa845ff50d471f8

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Do this
Then this
Then this

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist

yvonnetangsu commented 3 years ago

@andrewbaraniuk - Good catch! I think we never updated the link colors in Decanter 6. Thanks for this PR. Let me check with our designers on hover/focus states on these links (don't think we have it documented currently) and I'll get back to you.

yvonnetangsu commented 3 years ago

Forgot one - please add a letter-spacing: 0.1em to the alert label (eg, WARNING, SUCCESS) and the Dismiss button text as well. Thanks!

andrewbaraniuk commented 3 years ago

letter-spacing: 0.1em

Done!

yvonnetangsu commented 3 years ago

@sherakama Think we could punch a release for this one so we could use it for Giving?

sherakama commented 3 years ago

Sure

sherakama commented 3 years ago

@yvonnetangsu https://github.com/SU-SWS/decanter/releases/tag/6.2.3

yvonnetangsu commented 3 years ago

@sherakama Thanks a bunch!