SU-SWS / decanter

A collection of front end web resources.

GNU General Public License v3.0

41 stars 9 forks source link

Update _lockup.scss #846

Closed sherakama closed 3 years ago

sherakama commented 3 years ago

READY FOR REVIEW/NOT READY

(Edit the above to reflect status)

Summary

TL;DR - what's this PR for?

Needed By (Date)

When does this need to be merged by?

Urgency

How critical is this PR?

Steps to Test

Do this
Then this
Then this

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

See Also

PR Checklist

yvonnetangsu commented 3 years ago

Hmmm odd....seems like they're still not showing up 🤔 https://deploy-preview-846--decanter-v6.netlify.app/component/identity-lockup/

yvonnetangsu commented 3 years ago

I sort of remember that the formatting of the twig comments was really finicky. Maybe even moving that comment to the top breaks it because it creates a 2nd paragraph.

sherakama commented 3 years ago

This (https://github.com/SU-SWS/decanter-web/pull/89/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R43) Will need to change to this branch in order to pull the new build

yvonnetangsu commented 3 years ago

@sherakama Does this need a beta tag before merging?

sherakama commented 3 years ago

We don't have an auto release in v6. I suppose I could pull that back.