SU-SWS / decanter

A collection of front end web resources.
GNU General Public License v3.0
41 stars 9 forks source link

feat: Add font-display swap support to font loading #892

Closed callinmullaney closed 1 year ago

callinmullaney commented 1 year ago

READY FOR REVIEW

Summary

Needed By (Date)

Urgency

Steps to Test

  1. Review each google font link imported in CSS. Verify the corresponding stylesheets load with the @font-face selector including the font-display: swap property.

Affected Projects or Products

See Also

yvonnetangsu commented 1 year ago

Add

Hmm I'm generally ok with this, except for perhaps the Stanford logo font 🤔 I actually have tested the display=swap before, but it creates a flash of different fonts which I think is fine for text, but not sure if we want that for the Stanford logo? It will show the logo as a serif fallback font before the Stanford font finish loading. I don't feel too strongly about it but perhaps UComm branding might have issues with that 🤷🏼‍♀️

cc @iamrentman @callinmullaney

iamrentman commented 1 year ago

Thanks @yvonnetangsu. I agree, not with the Stanford ligature font.

That is, let's remove from Stanford font.

callinmullaney commented 1 year ago

Thank you @iamrentman and @yvonnetangsu for taking a look at this pull request. I've removed the font-display: swap; from the stanford @font-face. Back to you!

yvonnetangsu commented 1 year ago

@sherakama I think this PR is ready to merge but do we have a problem with the PR labeler? I seem to remember you removed it in another repo.

sherakama commented 1 year ago

I think this PR is ready to merge but do we have a problem with the PR labeler? I seem to remember you removed it in another repo.

Yeah, it doesn't have a lot of value for us so I have been removing it.

sherakama commented 1 year ago

GTG