Closed yvonnetangsu closed 1 year ago
@sherakama Not sure if there's an ADAPT ticket related to the Source Sans and Serif font update. If there is, please LMK 😄 I want to update it in Decanter v6 first, then I can use it in Giving.
@sherakama Not sure if there's an ADAPT ticket related to the Source Sans and Serif font update. If there is, please LMK 😄 I want to update it in Decanter v6 first, then I can use it in Giving.
I thought we added something... Couldn't find it.
Here you go: https://stanfordits.atlassian.net/browse/ADAPT-5863
@sherakama This is strange, I just pushed up a new commit with the browserslist update to defaults
with a few dist file changes due to running npm run publish
, but I'm not seeing the new commit here 😬 GitHub status seems ok.
Screenshot from my SourceTree 👀
@sherakama This is so strange, the update browerslistrc commit was lost on this GitHub page, but my jiggle commit is showing up, and now it's showing the previously invisible commit with the browerslistrc update now 😬
Hi @yvonnetangsu and @sherakama , The only thing I noticed was that I would like to keep the 900 weight. I will check in with the Core slack channel to make sure there's no issues. I'm super stoked. :)
Hi @yvonnetangsu and @sherakama , The only thing I noticed was that I would like to keep the 900 weight. I will check in with the Core slack channel to make sure there's no issues. I'm super stoked. :)
Good morning @jenbreese ! The 900 weight stays for Decanter 6. Just want to give people a heads up that it's not in Decanter 7 core (it hasn't been) 😄
@sherakama Do you think I should bump this up a minor version instead of just patch 🤔 ?
Merging as patch since user doesn't to do anything other than updating the Decanter version.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
npm run dev
,npm run start
, and inspect the text like I did here. It should tell you the rendered fonts are Source Sans 3Affected Projects or Products
Associated Issues and/or People
@mention
them here)See Also