SU-SWS / decanter

A collection of front end web resources.
GNU General Public License v3.0
41 stars 9 forks source link

ADAPT-5863 | Update to Source Sans 3 and Source Serif 4; minor updates #920

Closed yvonnetangsu closed 1 year ago

yvonnetangsu commented 1 year ago

READY FOR REVIEW

Summary

Needed By (Date)

Urgency

Steps to Test

  1. Look at code
  2. The preview is not really tied to this PR unfortunately, but you could pull this branch down locally, and do npm run dev, npm run start, and inspect the text like I did here. It should tell you the rendered fonts are Source Sans 3 Screenshot 2023-07-25 at 2 57 12 PM

Affected Projects or Products

Associated Issues and/or People

See Also

yvonnetangsu commented 1 year ago

@sherakama Not sure if there's an ADAPT ticket related to the Source Sans and Serif font update. If there is, please LMK 😄 I want to update it in Decanter v6 first, then I can use it in Giving.

sherakama commented 1 year ago

@sherakama Not sure if there's an ADAPT ticket related to the Source Sans and Serif font update. If there is, please LMK 😄 I want to update it in Decanter v6 first, then I can use it in Giving.

I thought we added something... Couldn't find it.

Here you go: https://stanfordits.atlassian.net/browse/ADAPT-5863

yvonnetangsu commented 1 year ago

@sherakama This is strange, I just pushed up a new commit with the browserslist update to defaults with a few dist file changes due to running npm run publish, but I'm not seeing the new commit here 😬 GitHub status seems ok.

yvonnetangsu commented 1 year ago

Screenshot 2023-07-25 at 4 25 30 PM Screenshot from my SourceTree 👀

yvonnetangsu commented 1 year ago

@sherakama This is so strange, the update browerslistrc commit was lost on this GitHub page, but my jiggle commit is showing up, and now it's showing the previously invisible commit with the browerslistrc update now 😬

jenbreese commented 1 year ago

Hi @yvonnetangsu and @sherakama , The only thing I noticed was that I would like to keep the 900 weight. I will check in with the Core slack channel to make sure there's no issues. I'm super stoked. :)

yvonnetangsu commented 1 year ago

Hi @yvonnetangsu and @sherakama , The only thing I noticed was that I would like to keep the 900 weight. I will check in with the Core slack channel to make sure there's no issues. I'm super stoked. :)

Good morning @jenbreese ! The 900 weight stays for Decanter 6. Just want to give people a heads up that it's not in Decanter 7 core (it hasn't been) 😄

yvonnetangsu commented 1 year ago

@sherakama Do you think I should bump this up a minor version instead of just patch 🤔 ?

yvonnetangsu commented 1 year ago

Merging as patch since user doesn't to do anything other than updating the Decanter version.