search

SU-SWS / decanter

A collection of front end web resources.
GNU General Public License v3.0
41 stars 9 forks source link

D8CORE-7111 | @jdwjdwjdw | Add Mastodon and google scholar icons and colors #940

Closed jdwjdwjdw closed 9 months ago

jdwjdwjdw commented 11 months ago

NOT READY FOR REVIEW

Summary

Needed By (Date)

Urgency

Steps to Test

  1. Do this
  2. Then this
  3. Then this

Affected Projects or Products

Associated Issues and/or People

See Also

netlify[bot] commented 11 months ago

Deploy Preview for decanter-v6 ready!

Name Link
Latest commit bab8c70e734d6e71ab2d9e25c958422038974e7c
Latest deploy log https://app.netlify.com/sites/decanter-v6/deploys/657a56a441b8470008e3f805
Deploy Preview https://deploy-preview-940--decanter-v6.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yvonnetangsu commented 11 months ago

@jdwjdwjdw I believe the fontawesome version we currently have doesn't have the 2 new icons - Google Scholar and Mastodon only available in FA v6.

jdwjdwjdw commented 11 months ago

@jdwjdwjdw I believe the fontawesome version we currently have doesn't have the 2 new icons - Google Scholar and Mastodon only available in FA v6.

Ah, thanks for the head's up @yvonnetangsu ! I'm seeing Mastodon in v5, but Google Scholar only in v6.

If I still wanted to use the Google Scholar FA logo, would the correct alternate step be to just download that svg and add it to our src/img folder?

yvonnetangsu commented 11 months ago

@jdwjdwjdw I believe the fontawesome version we currently have doesn't have the 2 new icons - Google Scholar and Mastodon only available in FA v6.

Ah, thanks for the head's up @yvonnetangsu ! I'm seeing Mastodon in v5, but Google Scholar only in v6.

If I still wanted to use the Google Scholar FA logo, would the correct alternate step be to just download that svg and add it to our src/img folder?

@jdwjdwjdw It's possible, but might need some update to the twig file and/or CSS depending on how the social media section is constructed :)

jdwjdwjdw commented 9 months ago

Closing this PR - I ended up adding this support into our Stanford Basic theme instead of within decanter.