search

SU-SWS / open_framework

Open Framework Drupal Theme
http://openframework.stanford.edu
GNU General Public License v2.0
209 stars 85 forks source link

Why are we custom defining block widths for sidebar? #251

Open meganem opened 10 years ago

meganem commented 10 years ago

why do we have this on line 305: .site-sidebar-first .block.well { width: calc(50% - 60px); }

When we really just need to add box-sizing: border-box; to those blocks:

.site-sidebar-first .block, .site-sidebar-second .block { -moz-box-sizing: border-box; -webkit-box-sizing: border-box; box-sizing: border-box; }

or add that class to line 298 to all these selectors (below) perhaps? Would this break the way we are defining responsive widths?

.main-top .block[class="span"], .main-upper .block[class="span"], .main-lower .block[class="span"], .main-bottom .block[class="span"], .content-top .block[class="span"], .content-upper .block[class="span"], .content-body .block[class="span"], .content-lower .block[class="span"], .content-bottom .block[class*="span"], .content-row2 .span6, .content-col2.row-fluid .span6, .content-row3 .span4, .content-col3.row-fluid .span4, .content-row4 .span3, .content-col4.row-fluid .span3, .site-sidebar-first .block, .site-sidebar-second .block

meganem commented 9 years ago

things aren't breaking right now, so it might not be worth changing this.