SU-SWS / stanford_ssp

Drupal module for configuring SimpleSAMLphp in Stanford web environments
GNU General Public License v2.0
9 stars 8 forks source link

D8CORE-4083 Use API V2 for the new workgroup API #111

Closed pookmish closed 3 years ago

pookmish commented 3 years ago

READY FOR REVIEW

Summary

Need Review By (Date)

Urgency

Steps to Test

  1. checkout this branch
  2. re-install a site and log in using saml
  3. verify you still get the expected role from the role mapping.

See Also

pookmish commented 3 years ago

I think a minor point release would be appropriate for this change. Since the available methods don't change it doesn't necessitate a major point release. But this is certainly more than a patch release.

sherakama commented 3 years ago

I think a minor point release would be appropriate for this change. Since the available methods don't change it doesn't necessitate a major point release. But this is certainly more than a patch release.

If the developer on the other end is expected to make a request to MAIS to get added to the new API make sure you call that out and make it VERY visible in the changelog and release notes.

pookmish commented 3 years ago

I think a minor point release would be appropriate for this change. Since the available methods don't change it doesn't necessitate a major point release. But this is certainly more than a patch release.

If the developer on the other end is expected to make a request to MAIS to get added to the new API make sure you call that out and make it VERY visible in the changelog and release notes.

That's mostly what the update hook checks for. The db update will fail if the certs are no longer functional on the new API.

sherakama commented 3 years ago

That's mostly what the update hook checks for. The db update will fail if the certs are no longer functional on the new API.

Yeah, unfortunately, there are still those out there that run updates on production sites and don't try before they buy.

pookmish commented 3 years ago

Yeah, unfortunately, there are still those out there that run updates on production sites and don't try before they buy.

Changelog and readme have been modified for 8.x-2.x version. https://github.com/SU-SWS/stanford_ssp/pull/111/commits/00f413654f9a1a1bd5b79c4256afd22578509b8a

imonroe commented 3 years ago

Shall I merge this, since everyone seems to be good with it?

pookmish commented 3 years ago

I'm ready for it :+1:

sherakama commented 3 years ago

Thanks, gents.