Fixed the destination path after saml login

[pookmish]

READY FOR REVIEW

Summary

• The contrib module actually expects the parameter ReturnTo, not destination. This fixes an issue when on an intranet site and attempt to go to the home page. Before, the destination failed to validate in the controller and so it fell back to the /user path. This passes the correct parameter with the expected string so that if a user lands on an intranet home page, they will log in and then go to the home page instead of their user page.
• https://git.drupalcode.org/project/simplesamlphp_auth/-/blob/8.x-3.x/src/Controller/SimplesamlphpAuthController.php#L150

Need Review By (Date)

• 9/15

Urgency

• medium

Steps to Test

1. Checkout this branch
2. configure your site to be intranet drush sset stanford_intranet 1; drush cr
3. load your home page in a browser
4. log in and verify you land back on the home page after logging in.
5. Check this with some incognito windows and attempt other paths before logging in
6. verify if you try to go to a path, then you log in, you still end up on that path after logging in.

See Also

• PR Checklist

[imonroe]

This works correctly for me, but I have one question. I notice when I log in, it sends me back to the home page as expected, but the context in the top admin bar, it drops me into the "user" section, rather than into the "manage" section.

Current behavior:

What I would expect:

Now, it may well be that dropping into the user section there is exactly the right thing to do for intranet logins; it makes sense, since in the majority of cases, the user is just logging in for read-only access rather than to modify the site, but I just want to check that it's indeed what we want to happen, rather than an unexpected side-effect.

[pookmish]

I think the toolbar thing is a cookie or something. I've never tracked down just how that is set because if you click on another toolbar item, it doesn't change with a page reload. so theres some type of cookie or something