issues
search
SU-SWS
/
stanford_ssp
Drupal module for configuring SimpleSAMLphp in Stanford web environments
GNU General Public License v2.0
9
stars
8
forks
source link
Revert su_display name_later hook.
#124
Closed
joegl
closed
2 years ago
joegl
commented
2 years ago
READY FOR REVIEW
Summary
Revert name alter hook which uses
su_display_name
field value to fix authored by bug
Review Tasks
Setup tasks and/or behavior to test
Check out this branch
Rebuild Cache and import config
drush cr ; drush ci
Navigate to...
Verify...
Site Configuration Sync
Is there a config:export in this PR that changes the config sync directory?
Front End Validation
[ ] Design is approved by @ user?
[ ] HTML validation: Is the markup using the appropriate semantic tags and
passes validation
? Or,
QA request ticket created
?
[ ] Cross-browser testing: Has been performed? Or,
QA request ticket created
?
[ ] Automated accessibility: Scans performed? Or,
QA request ticket created
?
[ ] Manual accessibility: Manually tested? Or,
QA request ticket created
?
Backend / Functional Validation
Code
[ ] Are the naming conventions following our standards?
[ ] Does the code have sufficient inline comments?
[ ] Is there anything in this code that would be hidden or hard to discover through the UI?
[ ] Are there any
code smells
?
[ ] Are tests provided? eg (unit, behat, or codeception)
Code security
[ ] Are all
forms properly sanitized
?
[ ] Any obvious
security flaws or new areas for attack
?
General
[ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
[ ] Is the approach to the problem appropriate?
Affected Projects or Products
Does this PR impact any particular projects, products, or modules?
Associated Issues and/or People
JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (
@mention
them here)
Resources
AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack
and link to
Browserstack Credentials
READY FOR REVIEW
Summary
su_display_name
field value to fix authored by bugReview Tasks
Setup tasks and/or behavior to test
drush cr ; drush ci
Site Configuration Sync
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mention
them here)Resources