SU-SWS / stanford_ssp

Drupal module for configuring SimpleSAMLphp in Stanford web environments

GNU General Public License v2.0

9 stars 8 forks source link

8.3.5 #144

Closed pookmish closed 1 year ago

pookmish commented 1 year ago

Fixed redirect route for adding user (#143)
8.3.5

NOT READY FOR REVIEW

(Edit the above to reflect status)

Summary

TL;DR - what's this PR for?

Review By (Date)

When does this need to be reviewed by?

Criticality

How critical is this PR on a 1-10 scale? Also see Severity Assessment.
E.g., it affects one site, or every site and product?

Urgency

How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

Check out this branch
Rebuild Cache and import config drush cr ; drush ci
Navigate to...
Verify...

Site Configuration Sync

Is there a config:export in this PR that changes the config sync directory?

Front End Validation

[ ] Design is approved by @ user?
[ ] HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
[ ] Cross-browser testing: Has been performed? Or, QA request ticket created?
[ ] Automated accessibility: Scans performed? Or, QA request ticket created?
[ ] Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

[ ] Are the naming conventions following our standards?
[ ] Does the code have sufficient inline comments?
[ ] Is there anything in this code that would be hidden or hard to discover through the UI?
[ ] Are there any code smells?
[ ] Are tests provided? eg (unit, behat, or codeception)

Code security

[ ] Are all forms properly sanitized?
[ ] Any obvious security flaws or new areas for attack?

General

[ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
[ ] Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials