Closed sherakama closed 6 years ago
Is this the same issue in https://stanfordits.atlassian.net/browse/SITES-745?
@sherakama you good with my changes?
@jbickar The long form of the array syntax is not the recommended syntax style.
Please see: https://www.drupal.org/docs/develop/standards/coding-standards#array
For readability, you may separate the nested arrays into multiple lines.
Huh. I learned something today.
Don't let it happen again.
I'm not a big fan of that, but OK, it's hard to argue with official coding standards.
How about now?
Code Climate has analyzed commit 67882f22 and detected 0 issues on this pull request.
View more on Code Climate.
Looks good to me.
Tank yew.
SITES-725
was a typo. SITES-745
is the actual JIRA issue.
That mistake shall die with this PR.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
See Also