SU-SWS / stanford_ssp

Drupal module for configuring SimpleSAMLphp in Stanford web environments
GNU General Public License v2.0
9 stars 8 forks source link

SITES-725: Found another avenue where destination was missing. #51

Closed sherakama closed 6 years ago

sherakama commented 6 years ago

READY FOR REVIEW

Summary

Needed By (Date)

Urgency

Steps to Test

  1. Check out this branch
  2. Navigate to an interior page as an anonymous user
  3. Click on the login link on the top right of the screen
  4. Be logged in and back on to the page you were just at

Affected Projects or Products

Associated Issues and/or People

See Also

jbickar commented 6 years ago

Is this the same issue in https://stanfordits.atlassian.net/browse/SITES-745?

jbickar commented 6 years ago

@sherakama you good with my changes?

sherakama commented 6 years ago

@jbickar The long form of the array syntax is not the recommended syntax style.

Please see: https://www.drupal.org/docs/develop/standards/coding-standards#array

sherakama commented 6 years ago

For readability, you may separate the nested arrays into multiple lines.

jbickar commented 6 years ago

Huh. I learned something today.

Don't let it happen again.

jbickar commented 6 years ago

I'm not a big fan of that, but OK, it's hard to argue with official coding standards.

jbickar commented 6 years ago

How about now?

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit 67882f22 and detected 0 issues on this pull request.

View more on Code Climate.

sherakama commented 6 years ago

Looks good to me.

Tank yew.

jbickar commented 6 years ago

SITES-725 was a typo. SITES-745 is the actual JIRA issue.

That mistake shall die with this PR.