SU-SWS / stanford_ssp

Drupal module for configuring SimpleSAMLphp in Stanford web environments

GNU General Public License v2.0

9 stars 8 forks source link

SITES-1109: Workgroups with underscores are invalidated #62

Closed jbickar closed 5 years ago

jbickar commented 5 years ago

READY FOR REVIEW

Summary

Fix bug where workgroups with underscores in them trigger an "Invalid workgroup format" error

Needed By (Date)

When does this need to be merged by? ASAP

Criticality

How critical is this PR on a 1-10 scale? 3/10

Steps to Test

Verify that this code is checked out on ACSF dev
Log in to https://inc00811537workgroupmapping-dev.sites.stanford.edu/sso/login
Verify that you get the "Underscore" role

(I already mapped ~jbickar:i_a to the "Underscore role and added you and me to that workgroup.)

Affected Projects or Products

Does this PR impact any particular projects, products, or modules? ACSF

Associated Issues and/or People

JIRA ticket: https://stanfordits.atlassian.net/browse/SITES-1109

See Also

PR Checklist

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 34ac5769 and detected 0 issues on this pull request.

View more on Code Climate.