SU-SWS / stanford_ssp

Drupal module for configuring SimpleSAMLphp in Stanford web environments
GNU General Public License v2.0
9 stars 8 forks source link

username, uid, and email settings description incorrect #65

Open tbfisher opened 5 years ago

tbfisher commented 5 years ago

in stanford_ssp_configuration_form() each of these settings state in the field description

"If the attribute is multivalued, the first value will be used."

however the getter functions

assume it is an array and always fetch the first value

sherakama commented 5 years ago

Oh I see, each of those functions is assuming array and should validate the value in the attributes array for single vs multiple values.

https://github.com/SU-SWS/stanford_ssp/blob/7.x-2.x/modules/stanford_simplesamlphp_auth/stanford_simplesamlphp_auth.inc#L578

An is_scalar check is needed here I suppose.