Improve make_plots.py - Githubissues

SUEPPhysics / SUEPCoffea_dask

SUEP analysis using coffea with fastjet. Uses Dask for batch submissions

3 stars 13 forks source link

Improve make_plots.py #254

Closed lucalavezzo closed 8 months ago

lucalavezzo commented 10 months ago

[ ] The configurations should come from a yaml file and be taken as an input, hardcoding as we do now is not sustainable.
[x] Consider adding a --channel [WH, ggF] (had to add one to get it to run for WH but maybe we can do it all from the configuration yaml?)
[x] Come up with a better solution for the output histograms. Maybe move to a separate file?
[x] Add function to calculate a new column of the dataframe using as inputs other columns. e.g. to calculate delta gen mass and reco mass

pmlugato commented 10 months ago

figure out which systematics are needed for WH, there is some repeated code in 'calculate systematic', and only if/else for scouting or not scouting.

pmlugato commented 10 months ago

(for now everything the same but no triggerSF weights)

lucalavezzo commented 8 months ago

2, 3, and 4 addressed in #279

lucalavezzo commented 8 months ago

I think for now we leave 1 as is, it's not ideal, but I don't want to change too many things all at once, it will just confuse everyone. We already moved where hists are defined in this PR. If it becomes a requested feature, or a problem in the future, we can revisit.