Feature/avoid page scrolling when drawer open prop

xmurcia commented 6 months ago

Category/Component

🔍 Show

Description, Motivation and Context

Allow a new prop to avoid the scroll on a page when the drawer is opened. The same feature is already implemented in the molecule/modal component.

Types of changes

[ ] 🪲 Bug fix (non-breaking change which fixes an issue)
[X] ✨ New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 🧾 Documentation
[X] 📷 Demo
[X] 🧪 Test
[ ] 🧠 Refactor
[ ] 💄 Styles
[ ] 🛠️ Tool

github-actions[bot] commented 6 months ago

	STATEMENTS	BRANCHES	FUNCTIONS	LINES
≍	≍ 0＝	≍ 0.06↑	≍ 0.07↑	≍ 0.07↑
%	75.92	63.83	65.69	77.62
ABS	3342 / 4402	1998 / 3130	653 / 994	3164 / 4076

andresin87 commented 6 months ago

tab navigation blocking is also implemented?

xmurcia commented 6 months ago

tab navigation blocking is also implemented?

This kind of behavior is not implemented, I guess you mean when the drawer is opened, to limit the scope of the focus just inside the drawer and not other DOM element, right? Maybe we can have a look in a different task in order to do it in modals and drawer because I've seen it is also missing in there.

SUI-Components / sui-components