search

SUI-Components / sui-components

SUI Components
https://sui-components.vercel.app/
MIT License
140 stars 59 forks source link

refactor(components/molecule/coachmark): Use div instead of p to wrap the step content #2752

Closed oriolpuig closed 2 months ago

oriolpuig commented 2 months ago

molecule/coachmark

🔍 Show

TASK:

Description, Motivation and Context

As you can see at the image below, currently we are wrapping the step content inside a <p>. It's not a good practice put inside a <p> some extra HTML such as a <div> for example. The validateDOMNEsting function is causing warning comments in our browser console or testing terminal.

We have decided to change it with a <div> because make more sense in terms of HTML.

Types of changes

Screenshots - Animations

image

github-actions[bot] commented 2 months ago
STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0＝ ≍ 0＝ ≍ 0＝ ≍ 0＝
% 75.9 64.19 65.99 77.7
ABS 3343 / 4404 2051 / 3195 654 / 991 3164 / 4072
github-actions[bot] commented 2 months ago
STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0＝ ≍ 0＝ ≍ 0＝ ≍ 0＝
% 75.9 64.19 65.99 77.7
ABS 3343 / 4404 2051 / 3195 654 / 991 3164 / 4072